Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technique] Activer l'authentification multifacteur pour l'accès des administrateurs au service #2653

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Jun 5, 2024

Ticket

#722

Description

Ajout d'une authentification a deux facteurs pour les admin

Pré-requis

make composer

Tests

  • Tenter de se connecter avec l'admin, vérifier que l'on est bien redirigé sur la page de demande du code reçu par email et valider son fonctionnement
  • Tenter de se connecter avec un utilisateur non admin et vérifier que rien n'a changé

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok !
Deux petits retours de code :)

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK, 1 petite remarque (et OK avec les remarques d'Emilien)

C'est tro pbien !!

src/Entity/User.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi !

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture, et retests OK

@hmeneuvrier hmeneuvrier merged commit f19c7b6 into develop Jun 6, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/722-admin-2fa branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants