Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Erreur annulation de visite #2676

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2670

Description

Ajout d'une vérification supplémentaire dans le SignalementVisitesController pour éviter une erreur sentry et afficher un message clair

Changements apportés

  • Changement du controlleur, on vérifie que la visite est bien dans le futur avant d'annuler la visite

Pré-requis

Vérifier l'heure de php/symfony en local

Tests

  • Planifier une visite pour dans 2 minutes (en fonction de l'heure de php/symfony)
  • Ouvrir la modale d'annulation de visite
  • Attendre 3 minutes, puis valider l'annulation
  • Vérifier qu'on a bien un message d'erreur explicite et que la visite n'est pas annulée

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et test

@emilschn emilschn merged commit b2e98d4 into develop Jun 11, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2670-qa-erreur-annulation-de-visite branch June 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants