Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Formats de fichiers non détectés #2685

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

@hmeneuvrier hmeneuvrier commented Jun 11, 2024

Ticket

#2669

Description

Ajout d'une nouvelle exception pour les fichiers vides (sera plus clair que Le format application/x-empty n'est pas supporté)
Ajout d'unfo sur le fichier dans l'erreur loguée dans Sentry (pour vérifier s'il faut ajouter des formats, extensions, autoriser l'absence d'extension etc.)

Changements apportés

  • Ajout d'une exception
  • Modification de SignalementFileProcessor

Pré-requis

Tests

  • CI ok

@hmeneuvrier hmeneuvrier force-pushed the bugfix/2669-qa-formats-de-fichiers-non-detectes branch from c7706a8 to 445fc6d Compare June 12, 2024 12:24
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture OK

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture ! La CI semble ok, je ne sais pas tester un fichier vide :)

@emilschn emilschn merged commit 54f90a4 into develop Jun 13, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2669-qa-formats-de-fichiers-non-detectes branch June 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants