Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BO - Tableau de bord] Corrections d'anomalies #921

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[BO - Tableau de bord] Corrections d'anomalies #921

merged 1 commit into from
Feb 15, 2023

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Feb 15, 2023 •
edited
Loading

Ticket

#785

Description

Apres des tests sur la préproduction, quelques problèmes ont été identifiés

  • Le correctif sur la requête SignalementRepository::countSignalementTerritory() n'est pas optimale sur un gros volume de données (fait planter la preprod)
  • Les widgets n'affichent pas les données - valeurs manquantes dans les props (sans doute un problème lié au conflit ?)
  • Le feature flipping ne fonctionne pas (conflit ?)

Changements apportés

  • Optimisation de la requête SignalementRepository::countSignalementTerritory()
  • Prise en compte du feature flipping
  • Valeurs passés au props pour les widgets

Tests

  • Activer le feature flpping et se rendre sur la plateforme
  • Désactiver le feature flipping et se rendre sur la plateforme

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sfinx13 sfinx13 marked this pull request as ready for review February 15, 2023 16:56
@sfinx13 sfinx13 changed the title fix: fix dashboard [BO - Tableau de bord] Corrections d'anomalies Feb 15, 2023
@sfinx13
Copy link
Collaborator Author

sfinx13 commented Feb 15, 2023

@emilschn @hmeneuvrier je mege afin qu'on puisse faire la demo demain

@sfinx13 sfinx13 merged commit d823b84 into develop Feb 15, 2023
@emilschn emilschn deleted the fix/785-dashboard branch February 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn Awaiting requested review from emilschn

@hmeneuvrier hmeneuvrier Awaiting requested review from hmeneuvrier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sfinx13