-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppression de la question sur le handicap (et de la donnée dans la BDD) #936
Conversation
@@ -62,7 +62,6 @@ private function loadSignalements(ObjectManager $manager, array $row) | |||
->setSuperficie($row['superficie']) | |||
->setLoyer($row['loyer']) | |||
->setDetails($row['details']) | |||
->setIsSituationHandicap(false) | |||
->setIsProprioAverti($row['is_proprio_averti']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
est-ce qu'il ne faudrait pas supprimer l'information des fixtures également pour avoir des fixtures "propres" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cette info n'est pas remplie dans les fixtures (sauf erreur de ma part)
@@ -62,7 +62,6 @@ public function getMapping(): array | |||
'code insee occupant' => 'inseeOccupant', | |||
'date visite' => 'dateVisite', | |||
'Occupant présent lors de la visite ?' => 'isOccupantPresentVisite', | |||
'Occupant en situation handicap' => 'isSituationHandicap', | |||
'etage occupant' => 'etageOccupant', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudra penser à modifier le template modèle qu'on fournit aux territoires pour les imports (qui a la main là-dessus ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span class="fr-badge fr-badge--info fr-m-1v {{ visible ?? '' }}">TOUS</span> | ||
</div> | ||
</div>#} | ||
<div class="fr-grid-row fr-grid-row--gutters"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce code commenté correspond à du code non-commenté dans le SearchFilterService (je ne sais pas pourquoi), à mon avis, soit on supprime tout, soit on laisse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attendons encore un peu avant le supprimer dans le service, on n'a pas encore de test sur ce service, ok pour la suppression du twig (c'est commenté depuis la création du projet sur github)
Test ok |
@@ -62,7 +62,6 @@ public function getMapping(): array | |||
'code insee occupant' => 'inseeOccupant', | |||
'date visite' => 'dateVisite', | |||
'Occupant présent lors de la visite ?' => 'isOccupantPresentVisite', | |||
'Occupant en situation handicap' => 'isSituationHandicap', | |||
'etage occupant' => 'etageOccupant', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -218,6 +216,6 @@ public function testCreateSignalementIsValid() | |||
$this->assertEmpty($signalement->getModifiedBy()); | |||
$this->assertEmpty($signalement->getAffectationStatusByPartner()); | |||
|
|||
$this->assertCount(84, $data, 'Array $data should have 84 keys'); | |||
$this->assertCount(83, $data, 'Array $data should have 83 keys'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signalement c'est tellement touchy que t'ai obligé d'avoir ce genre de test :-D
<span class="fr-badge fr-badge--info fr-m-1v {{ visible ?? '' }}">TOUS</span> | ||
</div> | ||
</div>#} | ||
<div class="fr-grid-row fr-grid-row--gutters"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attendons encore un peu avant le supprimer dans le service, on n'a pas encore de test sur ce service, ok pour la suppression du twig (c'est commenté depuis la création du projet sur github)
…feature/917-remove-question-handicap
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
J'ai repassé vos retours. Pour moi, c'est ok. Je vous laisse voir pour le merge :) |
Ticket
#917
Description
Suppression de la question sur le handicap dans le formulaire front, dans les imports, dans l'affichage back.
Tests
make load-migrations