Limit banner children prop to string type in main window banner stack

MTES-MCT · May 2, 2024 · 5fc1e09 · 5fc1e09
1 parent 252b34d
commit 5fc1e09
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 10 deletions.
diff --git a/frontend/src/features/MainWindow/components/BannerStack/Item.tsx b/frontend/src/features/MainWindow/components/BannerStack/Item.tsx
@@ -1,7 +1,7 @@
 import { Banner, type BannerProps } from '@mtes-mct/monitor-ui'
 import styled from 'styled-components'
 
-import type { BannerStackItemProps } from './types'
+import type { BannerStackItemProps } from '../../types'
 import type { Promisable } from 'type-fest'
 
 type ItemProps = {

diff --git a/frontend/src/features/MainWindow/components/BannerStack/types.ts b/frontend/src/features/MainWindow/components/BannerStack/types.ts
diff --git a/frontend/src/features/MainWindow/dispatchers/addMainWindowBanner.ts b/frontend/src/features/MainWindow/dispatchers/addMainWindowBanner.ts
@@ -1,6 +1,6 @@
 import { bannerStackAdapter, mainWindowActions } from '../slice'
 
-import type { BannerStackItemProps } from '../components/BannerStack/types'
+import type { BannerStackItemProps } from '../types'
 import type { HomeAppThunk } from '@store/index'
 
 /**

diff --git a/frontend/src/features/MainWindow/slice.ts b/frontend/src/features/MainWindow/slice.ts
@@ -1,6 +1,6 @@
 import { createEntityAdapter, createSlice, type EntityState, type PayloadAction } from '@reduxjs/toolkit'
 
-import type { BannerStackItem } from './components/BannerStack/types'
+import type { BannerStackItem } from './types'
 
 export const bannerStackAdapter = createEntityAdapter({
   selectId: (bannerStackItem: BannerStackItem) => bannerStackItem.rank,

diff --git a/frontend/src/features/MainWindow/types.ts b/frontend/src/features/MainWindow/types.ts
@@ -1,3 +1,13 @@
+import type { BannerProps } from '@mtes-mct/monitor-ui'
+
+export type BannerStackItem = {
+  props: BannerStackItemProps
+  rank: number
+}
+export type BannerStackItemProps = Omit<BannerProps, 'chilren' | 'onAutoClose' | 'onClose' | 'top'> & {
+  children: string
+}
+
 export enum MainWindowConfirmationModalActionType {
   'DELETE_CONTROL_UNIT_CONTACT' = 'DELETE_CONTROL_UNIT_CONTACT',
   'DELETE_CONTROL_UNIT_RESOURCE' = 'DELETE_CONTROL_UNIT_RESOURCE'