Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mission] Allègement des champs en erreur #1249

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

claire2212
Copy link
Collaborator

@claire2212 claire2212 commented Mar 7, 2024

@claire2212 claire2212 added the feat. enhancement Amélioration/évolution d'une fonctionnalité label Mar 7, 2024
@claire2212 claire2212 self-assigned this Mar 7, 2024
@claire2212 claire2212 requested review from ivangabriele, thoomasbro and louptheron and removed request for ivangabriele and thoomasbro March 8, 2024 16:21
Copy link
Collaborator

@thoomasbro thoomasbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Je n'ai pas vu les échanges sur le fait de retirer UTC des étiquettes de champs. Il me semble que ça avait été un sujet au début des missions car les heures saisies étaient les heures locales notamment dans les DTOM.

@claire2212
Copy link
Collaborator Author

@thoomasbro , oui j'aurais dû préciser. On l'enlève des champs mais on ajoute l'info dans le bandeau du bas: https://github.com/MTES-MCT/monitorenv/pull/1249/files#diff-22635eef3660c4c86393f07b05dd8b6294419d771187991560fe640184d9ea76R68

@claire2212 claire2212 force-pushed the claire/clean-error-messages-in-mission-form branch from ce3237e to c03e387 Compare March 13, 2024 08:46
@claire2212 claire2212 merged commit 187650a into main Mar 13, 2024
19 checks passed
@claire2212 claire2212 deleted the claire/clean-error-messages-in-mission-form branch March 13, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat. enhancement Amélioration/évolution d'une fonctionnalité
Projects
None yet
2 participants