Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mission] Pouvoir sauvegarder une mission terminée même si des champs sont manquants #1377

Merged
merged 3 commits into from
May 16, 2024
Merged

[Mission] Pouvoir sauvegarder une mission terminée même si des champs sont manquants #1377

merged 3 commits into from
May 16, 2024

Conversation

claire2212
Copy link
Collaborator

Related Pull Requests & Issues

  • Tests E2E (Cypress)

@claire2212 claire2212 added the bug Something isn't working label May 16, 2024
@claire2212 claire2212 self-assigned this May 16, 2024
louptheron
louptheron approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frontend/src/features/missions/MissionForm/CancelEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/features/missions/MissionForm/utils.ts Outdated Show resolved Hide resolved
@claire2212 claire2212 merged commit fcd6157 into main May 16, 2024
20 checks passed
@claire2212 claire2212 deleted the claire/save-mission-with-missing-fields branch May 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron approved these changes

Assignees

@claire2212 claire2212

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible de modifier une mission avec MED en attente
2 participants
@claire2212 @louptheron