[MonitorExt] Mise en place de MonitorExt #1441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
requested changes
Jun 11, 2024
frontend/src/features/map/index.tsx
Outdated
| @@ -77,65 +77,65 @@ export function Map() { | |||
|
|
|||
| {/* MAP */} | |||
| {/* @ts-ignore */} | |||
| <MeasurementLayer /> | |||
| {isSuperUser && <MeasurementLayer />} | |||
There was a problem hiding this comment.
suggestion : Regrouper les composants qui doivent vérifier qu'on doit etre SuperUser
There was a problem hiding this comment.
non on ne peut pas car on doit passer les props de BaseMap, le fait d'ajouter <></>empêche ça
There was a problem hiding this comment.
Ok mais on peut c'est possible d'avoir quelque chose dans le genre ?
{!isSuperUser ? <BaseMap>..</BaseMap> : <BaseMap></BaseMap> Avec les layers qui vont bien dans chacun des cas ?
frontend/src/pages/Login.tsx
Outdated
| @@ -27,7 +27,7 @@ export function Login() { | |||
| return <Navigate to="/" /> | |||
| } | |||
|
|
|||
| if (auth?.isAuthenticated && isSuccess && user?.isSuperUser) { | |||
| if (auth?.isAuthenticated && isSuccess && !user?.isSuperUser) { | |||
|
suggestion: Ajouter des tests e2e pour vérifier de ce que l'ont voit en lecture seule. (si c'est pas trop compliqué) |
claire2212
force-pushed
the
claire/add-monitor-ext
branch
from
1f0f6d9
to
0d40b59
Compare
maximeperraultdev
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues