Waf run_python_tests fixes #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler now produces a SyntaxWarning when identity checks (is and is not) are used with certain types of literals (e.g. strings, numbers). These can often work by accident in CPython, but are not guaranteed by the language spec. The warning advises users to use equality tests (== and !=) instead. (Contributed by Serhiy Storchaka in bpo-34850.) https://bugs.python.org/issue34850
This behavior was observed when running the Python tests from Waf (python ./waf run_python_tests) The script creates a local Python package and sets PYTHONPATH to run the tests ignoring existing entries This commit proposes appending our local package to the existing PYTHONPATH to prevent ignoring existing entries
alastair
reviewed
Jul 6, 2020
| @@ -339,7 +339,7 @@ def run_python_tests(ctx): | |||
| os.system('cp -r src/python/essentia build/python/') | |||
| os.system('cp build/src/python/_essentia*.so build/python/essentia') | |||
|
|
|||
| ret = os.system('PYTHONPATH=build/python %s test/src/unittests/all_tests.py' % sys.executable) | |||
| ret = os.system('PYTHONPATH=build/python:$PYTHONPATH %s test/src/unittests/all_tests.py' % sys.executable) | |||
There was a problem hiding this comment.
Maybe it'd be a good idea to use subprocess.run (python 3.5 and above), which takes a specific env argument, allowing us to run this without using a subshell.
Double-check that this is valid if there is a space in $PYTHONPATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes for the
run_python_testWaf method:Replace 'is not' by '!=' for literals, which throws a warning in Python 3.8.
Don't overwrite PYTHONPATH when running the unit tests, so the user's required packages located in PYTHONPATH directories are correctly loaded.
This solves one of the issues described in #914