Search "frontend" refactor #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#1741
Description
This PR includes a huge refactor of the search "frontend" code and provides a new way of defining options for the search page based on a
SearchQueryProcessorandSearchOptionclasses which are somehow inspired by the way Django forms work.This PR also includes refactoring of the search clustering feature which was never tested with the new UI. Once merged, the clustering feature will be available only for users with special permissions.
Deployment steps:
The clustering feature works as another async task for the celery workers, so these will need to be re-deployed (and the new clustering queue added to their deployment configuration file). Also static files will need to be rebuilt. Other than that it should be like a normal deployment :)