Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove demos/MoodTagger #89

Closed
alastair opened this issue Jan 9, 2020 · 9 comments · Fixed by #108 or #121
Closed

Remove demos/MoodTagger #89

alastair opened this issue Jan 9, 2020 · 9 comments · Fixed by #108 or #121

Comments

@alastair
Copy link
Member

alastair commented Jan 9, 2020

This demo has lots of hard-coded paths, is windows-based, and relies on remote controlling winamp. There's also no documentation, it seems like it might be better to just remove it rather than try and make it work.

@alastair
Copy link
Member Author

alastair commented Jan 9, 2020

Other files that could be removed:

  • src/bindings/pygaia/essentia.py
  • src/bindings/pygaia/Gaia2 Python module.e4p
  • src/bindings/pygaia/mtgdb (replace with an MTG-specific repo, keep this out of gaia)
  • src/bindings/pygaia/linalg (doesn't seem to be used, some other stuff uses linalg package from numpy)
  • test/scratch (a bunch of experiments? put them in a better place if they're good)
  • scripts/classification/generate_essentia_models.py, generate_classification_project_mtgdb.py
  • scripts/collections (is this specific to our collections too?)
  • rpm build file
  • deb build

@dbogdanov
Copy link
Member

Agreed, MoodTagger should be removed in a separate PR.

@dbogdanov
Copy link
Member

dbogdanov commented Mar 17, 2020

We now have a repository with the scripts we are currently using to build MTGDB models:
https://github.com/MTG/mtgdb-models

Therefore, src/bindings/pygaia/mtgdb and src/bindings/pygaia/essentia.py are also obsolete.

One thing missing in the new repository is a default list and metadata of the datasets (see DATASETS_DATA and DATASETS_GROUNDTRUTH variables). Perhaps those could be added or document better DATASETS_DATA and DATASETS_GROUNDTRUTH in the README instead? @pabloEntropia

The code in scripts/collections should be also removed. Again, we need make sure that the new repository does have similar consistency checks when training the models to ensure that all training collections are valid (e.g., no missing audio files with respect to the ground truth metadata). I would expect that this is so already, please confirm (@pabloEntropia).

Get rid of scripts/classification/generate_essentia_models.pyand generate_classification_project_mtgdb.py too.

@dbogdanov
Copy link
Member

I would create a separate issue for test/scratchand those can be recycled to make a nice jupyter notebook tutorial for similarity and classification in Gaia (a task for me).

@dbogdanov
Copy link
Member

src/bindings/pygaia/linalg contains a helper function for the Gaia's PCA. It's not used in the examples, but it can be useful. Perhaps to be merged with other helper functions we can come up with after writing a tutorial.

@dbogdanov
Copy link
Member

Get rid of src/bindings/pygaia/Gaia2 Python module.e4p too.

alastair added a commit that referenced this issue Mar 19, 2020
This was a very old, unmaintained windows demo.
Fixes #89
@alastair
Copy link
Member Author

reopening because we have a few other pending items here to finishing

@alastair alastair reopened this Mar 19, 2020
dbogdanov added a commit that referenced this issue Oct 13, 2022
Some legacy code for experiments not related to main Gaia (#89).
@dbogdanov
Copy link
Member

Everything is addressed in expect for rpm build and deb build files (open a new issue for them).

@dbogdanov
Copy link
Member

Fixed in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants