Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonObjectLoader - Prevent serializing of back-references #11

Closed
sven-n opened this issue Jan 10, 2018 · 0 comments
Closed

JsonObjectLoader - Prevent serializing of back-references #11

sven-n opened this issue Jan 10, 2018 · 0 comments
Labels
bug up-for-grabs

Comments

@sven-n
Copy link
Member

sven-n commented Jan 10, 2018

I tried to get the JsonObjectLoader working for Accounts, as their structure can get very complex, too. Imagine an account filled full of items which have a lot of item options...

This generally works but has some issues. For example an ItemStorage loads it's items, and items load the item storage which tries to load it's items again... and so on. So the JsonObjectLoader needs some adjustments to handle this case.
See also #10.
@sven-n sven-n mentioned this issue Jan 10, 2018
Closed
sven-n added a commit that referenced this issue Jan 10, 2018
@sven-n
Added some tests for the json query builder
9dd9075 
Should help when investigating #11.
sven-n added a commit that referenced this issue Feb 17, 2018
@sven-n
Prevent serializing of back references. However, they are serialized …
4587fdd 
…as $ref-objects, so they can be resolved.

See also #11
sven-n added a commit that referenced this issue Feb 17, 2018
@sven-n
Added resolver for back references
edd955e 
To resolve back-references in case we load Accounts, we should use some
separate resolver and not use the resolver which resolves configuration
objects. Because the serializer needs one resolver, we implemented a
MultipleSourceReferenceResolver.
See also #11
@sven-n sven-n closed this as completed in d810522 Feb 17, 2018
sven-n added a commit that referenced this issue Feb 17, 2018
@sven-n
Switched account loading to always use json queries
708d37a 
See also #11
@sven-n sven-n mentioned this issue Mar 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sven-n