Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MW >= 1.25 token handling #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

reedy
Copy link

@reedy reedy commented Jul 30, 2021

Closes #120

@Jarry1250
Copy link
Contributor

Hi Sam. Thanks for doing this. Think there's a syntax error on line 2323 of Wiki.php though. Should read $tokens['query']['tokens'] (to reflect the usse of the new query API).

@reedy
Copy link
Author

reedy commented Oct 12, 2021

It's not a syntax error if it's syntactically valid ;).

@reedy
Copy link
Author

reedy commented Oct 12, 2021

Also, it would've worked fine. It just looked a bit odd

@reedy
Copy link
Author

reedy commented Oct 12, 2021

Actually, no.. It was right the first time

@Jarry1250
Copy link
Contributor

Jarry1250 commented Oct 23, 2021

Are you sure? It doesn't work for me. I get "Notice: Undefined index: tokens in /data/project/jarry-common/public_html/peachy/Includes/Wiki.php on line 2323" followed by "Warning: Invalid argument supplied for foreach() in /data/project/jarry-common/public_html/peachy/Includes/Wiki.php on line 2323" followed by "Error retrieving userrights token...". Whereas if I make the change it works perfectly. This is on en.wp.

Edit: Or perhaps we are using different apiQuery functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using action=tokens API function.
3 participants