Skip to content

Commit

Permalink
Fixed build issue which caused 'illegal instruction' errors whenever …
Browse files Browse the repository at this point in the history
…mwalib called CFITSIO functions.
  • Loading branch information
gsleap committed Oct 5, 2023
1 parent b66df32 commit 8b5e3d2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@ curl "https://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/cfitsio-3.49.tar.gz" -
tar -xf cfitsio.tar.gz
rm cfitsio.tar.gz
cd cfitsio-3.49
# Enabling SSE2/SSSE3 could cause portability problems, but it's unlikely that anyone
# is using such a CPU...
# https://stackoverflow.com/questions/52858556/most-recent-processor-without-support-of-ssse3-instructions
# Disabling curl just means you cannot fits_open() using a URL.
CFLAGS="-O3" ./configure --prefix=/usr/local --enable-reentrant --enable-sse2 --enable-ssse3 --disable-curl
./configure --prefix=/usr/local --enable-reentrant --disable-curl

if [[ "$OSTYPE" == "linux-gnu"* ]]; then
make -j
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@

Changes in each release are listed below.

## 1.1.1 5-Oct-2023

* Fixed build issue which caused 'illegal instruction' errors whenever mwalib called CFITSIO functions.

## 1.1.0 13-Sep-2023

* BREAKING CHANGE: `VoltageContext::read_second` and `read_file` now return signed bytes (`i8`) instead of unsigned (`u8`). This is a very breaking change for existing clients using these functions, but it is necessary to return the correct interpretation of the bytes to the client.
* Python classes and methods now have docstrings.
* Python classes and methods now have docstrings.

## 1.0.1 12-Sep-2023

Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mwalib"
version = "1.1.0"
version = "1.1.1"
homepage = "https://github.com/MWATelescope/mwalib"
repository = "https://github.com/MWATelescope/mwalib"
readme = "README.md"
Expand Down

0 comments on commit 8b5e3d2

Please sign in to comment.