Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ethereum-org-website component integration #14

Closed
wants to merge 1 commit into from

Conversation

nathanhleung
Copy link
Collaborator

@nathanhleung nathanhleung commented May 14, 2021

This PR begins the process of integrating ethereum-org-website components into the site.

Major changes:

  1. The ethereum-org-website components depend on some top-level providers being present, so I created a <Root/> component which wraps every Docusaurus page to ensure those providers are present
  2. The ethereum-org-website components require an extra Babel plugin, so I had to create a custom Docusaurus plugin to override the default Babel configuration

Apologies for the messy diff! I think a lot of it is my Prettier extension. I can set up a Prettier config and run it over the entire repo first in a separate PR if you want a cleaner diff.

Before

Old card component

Screen Shot 2021-05-13 at 10 57 29 PM

After

New card component from ethereum.org

Screen Shot 2021-05-13 at 10 57 04 PM

@nathanhleung nathanhleung requested a review from MYKatz May 14, 2021 02:56
@MYKatz
Copy link
Collaborator

MYKatz commented May 17, 2021

Looks great when running locally, but we're running into a build error (both on netlify and on my machine) -- try running yarn build.

Do you think you'll have the bandwidth to figure it out? @nathanhleung. If not I will take a crack at it later this week.

@evanmays
Copy link
Collaborator

@nathanhleung Try rebasing, it could have been from when I pulled a Chad and broke master

@nathanhleung
Copy link
Collaborator Author

Looks great when running locally, but we're running into a build error (both on netlify and on my machine) -- try running yarn build.

Do you think you'll have the bandwidth to figure it out? @nathanhleung. If not I will take a crack at it later this week.

damn this looks like a messy issue based on the link in the build log on netlify. maybe give it a shot @MYKatz? also try @evanmays rebasing suggestion?

can get to this on the weekend if need be too

@nathanhleung nathanhleung force-pushed the nathanhleung-restyle branch 2 times, most recently from f02c7d0 to 45d10d5 Compare July 12, 2021 17:54
@nathanhleung
Copy link
Collaborator Author

i'm just gonna copy and paste from the ethereum website repo instead this is too complicated

@nathanhleung nathanhleung deleted the nathanhleung-restyle branch July 12, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants