Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZPOPMIN and ZPOPMAX #18

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@MatthewEdge
Copy link

commented Mar 1, 2019

Attempts to surface the ZPOPMIN and ZPOPMAX APIs for Sorted Sets.

Apologies in advanced if I mixed up the api/SortedSets definitions. I'm still getting comfortable with the library's lower constructs :D Please let me know if I've missed anything!

@coveralls

This comment has been minimized.

Copy link

commented Mar 1, 2019

Pull Request Test Coverage Report for Build 100

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 90.629%

Files with Coverage Reduction New Missed Lines %
src/main/scala/redis/Sentinel.scala 1 73.17%
Totals Coverage Status
Change from base Build 73: -0.02%
Covered Lines: 1470
Relevant Lines: 1622

💛 - Coveralls
@kardapoltsev

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2019

LGTM. Thank you!

@kardapoltsev kardapoltsev merged commit 4a2dd2a into Ma27:master Mar 1, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 90.629%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.