CMakeLists.txt: fix build without C++ #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you elaborate more on what this improvement brings? |
Cmake enforces some stuff based on the CMakeList.txt. By default, it will enforce a C and C++ compiler. And while it often goes together (most GCC builds do), it's not guaranteed. E.g. Buildroot has support for C-only toolchains. This commit makes sure that only C is required. And the intention is that fluent-bit takes this along at some point so that we can drop our patch in Buildroot. |
lwrb is written in c, so only enforce a c compiler Seen while compiling fluent-bit on buildroot. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
force-pushed
the
bugfix/no-c++
branch
from
4a4f44c
to
a4de106
Compare
1 task
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 25, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
1 task
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 25, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 26, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 27, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 29, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 29, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
May 4, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
leonardo-albertovich
pushed a commit
to fluent/fluent-bit
that referenced
this pull request
May 8, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
andreswebs
pushed a commit
to andreswebs/fluent-bit
that referenced
this pull request
May 9, 2023
lwrb is written in c, so only enforce a c compiler upstream: MaJerle/lwrb#26 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lwrb is written in c, so only enforce a c compiler
Seen while compiling fluent-bit on buildroot.