This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
Update php version to pass tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
physikerwelt
reviewed
Mar 3, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM php:7.4-cli | |||
| FROM php:8.0-cli | |||
There was a problem hiding this comment.
How did you choose that version? The other container uses 8.1
I think it would be better to use the same version to avoid additional conflicts at some point in time.
There was a problem hiding this comment.
Oh, I was not aware of that. I just assumed 8.0. I've updated it now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
Instructions for PR review:
Checklist for this PR: