fix: optimization getLocaleDate performances #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Open the Gantt chart component, found the fps drop, only 23fps minimum
Through Chrome Devtools Performance analysis, it is found that
longtask
is more serious. AndtoLocaleDateString
takes a long time:The
toLocaleDateString
function takes a long timethe root cause seem to be that instantiates a new Intl.DateTimeFormat every time toLocaleString is called, which has a relatively high cost. (moment/luxon#352)
Solution
Since there will only ever be a very limited number of formats, those format instances should be cached after creation. This reduces the runtime of toLocaleString cost by a factor of 10.
Final Results
Through optimization,
FPS
has been improved by 10%. After the upgrade, the lowest reached 28fps