fix: optimize scroll #194
Closed
fix: optimize scroll #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlbajramiKevin I had same issues and i downloaded ur code and looks good but if i set ganttHeight={540} for example, verticall scroll doesnt work. |
|
Yeah, I did those fixes and then noticed that if you set a max value for height it will break things. You could try placing that in a container somewhere, but my advice would be to not use this library tbh. If its a for a personal project thats fine, but for a real product I would suggest to look elsewhere or create something from scratch. |
|
Yes! I agree but we already use it so I have to fix those issues :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optmizes the scroll by relying on css and not stated.
The existing solution was causing far too many rerenders because of a useEffect that was calling setStateX while being dependent on stateX. I just did a bunch of css changes, to make the overall scroll feel way more natural and simple.
Dont feel I broke anything, but still fail to understand what was the point of doing the scroll in tehe way that it was before.
Didnt clean the entire project, since I ran into another coupld of major bugs that need fast fixes.