Add a note about why there is no timeout in the processes' terminate …

…method
MaZderMind · May 4, 2015 · d5a1ffb · d5a1ffb
1 parent 879c7c3
commit d5a1ffb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/python-api/gstswitch/process_monitor.py b/python-api/gstswitch/process_monitor.py
@@ -86,6 +86,9 @@ def terminate(self):
                 len(chunk))
             self._cmd_output_target.write(chunk)
 
+        # TODO: In python3 I'd add a timeout here but because of the forced
+        # python2 compatibility it's not that simple. Using subprocess32
+        # requires different patching in the unit-tests.
         self.log.debug("waiting for the subprocess to die")
         super(ProcessMonitor, self).communicate()