Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 远程控制对非 https 连接仅提出警告 #8061

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

SherkeyXD
Copy link
Member

@SherkeyXD SherkeyXD commented Jan 22, 2024

close #8053

来个人测测(

@github-actions github-actions bot added the MAA Team Opened by a member of the MAA Team label Jan 22, 2024
Copy link
Member

@KevinT3Hu KevinT3Hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断逻辑好像错了xd,localhost地址会在https那里就error掉(

@KevinT3Hu
Copy link
Member

而且用contains判断的话是不是会有办法绕开(
比如

http://xxx.xxx/localhost

这样

@Cryolitia
Copy link
Member

此外,应该允许用户在充分理解使用HTTP的危险性的前提下继续使用HTTP。对于运行在不可信平台上的开源软件,设置这种障碍毫无意义。

@SherkeyXD
Copy link
Member Author

那干脆把https的检测删了(

设置的时候提示下用户不安全就行了(?

@Cryolitia
Copy link
Member

不要拦着用户,警告差不多得了

@SherkeyXD
Copy link
Member Author

不要拦着用户,警告差不多得了

empty 的情况总得拦着吧)

@Cryolitia
Copy link
Member

empty 的情况总得拦着吧)

这怎么看也不是只拦empry啊

@SherkeyXD SherkeyXD changed the title feat: 远控支持localhost上的连接 feat: 远程控制对非 https 连接仅提出警告 Feb 6, 2024
@github-actions github-actions bot added the module: others shopping, visit, login, connection, etc. or may cause core changes label Feb 6, 2024
@SherkeyXD
Copy link
Member Author

这样应该可以了?

@SherkeyXD SherkeyXD merged commit 438e59e into MaaAssistantArknights:dev Feb 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAA Team Opened by a member of the MAA Team module: others shopping, visit, login, connection, etc. or may cause core changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

远控功能在HTTPS之外允许localhost endpoint
3 participants