-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 远程控制对非 https 连接仅提出警告 #8061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinT3Hu
suggested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
判断逻辑好像错了xd,localhost地址会在https那里就error掉(
而且用contains判断的话是不是会有办法绕开(
这样 |
Cryolitia
requested changes
Jan 23, 2024
此外,应该允许用户在充分理解使用HTTP的危险性的前提下继续使用HTTP。对于运行在不可信平台上的开源软件,设置这种障碍毫无意义。 |
那干脆把https的检测删了( 设置的时候提示下用户不安全就行了(? |
Cryolitia
requested changes
Jan 23, 2024
不要拦着用户,警告差不多得了 |
empty 的情况总得拦着吧) |
这怎么看也不是只拦empry啊 |
github-actions
bot
added
the
module: others
shopping, visit, login, connection, etc. or may cause core changes
label
Feb 6, 2024
这样应该可以了? |
Cryolitia
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MAA Team
Opened by a member of the MAA Team
module: others
shopping, visit, login, connection, etc. or may cause core changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8053
来个人测测(