Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Templates for new GUI (Siege) and fix #8503 #8510

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

Lemon-miaow
Copy link
Contributor

Fix #8503 #8507 #8509
May need more testing.

@github-actions github-actions bot added ambiguous Issue cannot be understood by Issue-bot or PR does not comply with Commitizen. client: WpfGui Issue about MaaWpfGui labels Mar 7, 2024
@Constrat
Copy link
Member

Constrat commented Mar 7, 2024

Looks good to me, but on a personal note I would suggest changing Siege to something like Rainbow or even better Rainbow6 (Or RainbowSix), because Siege is the official translation for 推进之王

@github-actions github-actions bot removed the ambiguous Issue cannot be understood by Issue-bot or PR does not comply with Commitizen. label Mar 7, 2024
@Lemon-miaow
Copy link
Contributor Author

Looks good to me, but on a personal note I would suggest changing Siege to something like Rainbow or even better Rainbow6 (Or RainbowSix), because Siege is the official translation for 推进之王

I was thinking Siege mainly because the Siege in RainbowSix:Siege translates to 彩虹六号:围攻(

@Constrat
Copy link
Member

Constrat commented Mar 7, 2024

Well, let's just hope they will never release a 推进之王 themed interface XD

Did you manage to test all the interfaces?

@Lemon-miaow
Copy link
Contributor Author

Lemon-miaow commented Mar 7, 2024

Well, let's just hope they will never release a 推进之王 themed interface XD

Did you manage to test all the interfaces?

I tried other interfaces just now and changed the roi. It all works for me, but I'm not sure if it works as well for others.

@Constrat
Copy link
Member

Constrat commented Mar 7, 2024

If you tested on 1280x720, it should work for the majority, as it seems themes are not resolution-bound

@Constrat
Copy link
Member

Constrat commented Mar 7, 2024

Thank you very much for your first contribution!

@Constrat Constrat changed the title Templates for new GUI (Siege) and fix #8503 feat: Templates for new GUI (Siege) and fix #8503 Mar 7, 2024
@Constrat Constrat enabled auto-merge (squash) March 7, 2024 18:22
@Constrat Constrat disabled auto-merge March 7, 2024 18:22
@Constrat Constrat merged commit 9da3312 into MaaAssistantArknights:dev Mar 7, 2024
2 of 4 checks passed
@Lemon-miaow
Copy link
Contributor Author

Thank you very much for your first contribution!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: WpfGui Issue about MaaWpfGui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

好友列表界面改动,访问好友获得信用功能出现图像识别异常
2 participants