Simplified UI flow

[x2048]

Hi Maarten,

I've streamlined the UI flow when the settings are already defined:

• Hotkey is always registered and allows to start recording immediately
• Systray click starts recording
• 'Start recording' in tray context is always enabled
• Closing window minimizes to tray, if tray is present
• Settings are validated before recording starts

This allows to start SSR as systray resident with --start-hidden if recording settings are not changed frequently and makes it really simple to use.

The default flow is unchanged, and --no-systray option allows to start window-only flow (e.g. to record GL applications etc).

--Dmitry

[MaartenBaert]

I'm not sure whether I agree with all of these changes. I don't like programs that hide in the system tray without being explicitly asked to do so. I understand you made that change so you could use left-clicking the system tray icon to start and stop the recording, but I don't think this is intuitive (most programs use left-clicking to show/hide the program, e.g. VLC and Transmission) or necessary (there's already a hotkey for this). It's also worth considering that some people have a broken systray which means they don't see the icon at all, even when it's enabled. Not a huge problem now, but it becomes a problem when SSR inexplicably keeps running in the background when they try to close it.

I do agree that starting the recording with the hotkey should work even when the recording page isn't active, so I will merge that change. I can add an option to enable the behaviour you describe once the new GUI is ready, but right now there's just not enough space for another checkbox, and I don't want it to be the default.

[MaartenBaert]

Hmm. As I suspected this interacts badly with modal dialogs. Press the hotkey multiple times when there is no file name, and you get multiple dialogs stacked on top of each other. Things get even worse when you press the hotkey while using the 'select rectangle' button - SSR basically deadlocks because you can't press the 'ok' button and you can't cancel the 'select rectangle' operation either. This will require some more changes.

[kn00tcn]

i know this is way old, but it's interesting to think about user interaction

middle click on tray icon makes more sense so that left click doesnt lose its common expectation & wont pop up the window when double clicking