Added custom exceptions

src/Cache.php

@@ -2,6 +2,8 @@
 namespace MaartenGDev;
 
 
+use MaartenGDev\Exceptions\BadMethodCallException;
+use MaartenGDev\Exceptions\CacheEntryNotFound;
 use MaartenGDev\Exceptions\CacheFileNotFoundException;
 
 class Cache implements CacheInterface
@@ -41,7 +43,7 @@ public function has($key, $callable = null)
 
 
         if($isCallable && !is_callable($callable)){
-            return false;
+            throw new BadMethodCallException('Invalid Callable provided');
         }
 
         if (!$this->storage->fileExists($key)) {
@@ -68,7 +70,7 @@ public function has($key, $callable = null)
     public function get($key)
     {
         if (!$this->isValid($key, $this->expire)) {
-            throw new \Exception('No Cache Entry found');
+            throw new CacheEntryNotFound('No cache entry found.');
         }
 
         return $this->storage->get($key);

src/Exceptions/BadMethodCallException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace MaartenGDev\Exceptions;
+
+use Exception;
+
+class BadMethodCallException extends Exception
+{
+
+}

src/Exceptions/CacheEntryNotFoundException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace MaartenGDev\Exceptions;
+
+class CacheEntryNotFound extends \Exception
+{
+
+}

src/Exceptions/CacheFileNotFoundException.php

@@ -2,7 +2,6 @@
 
 namespace MaartenGDev\Exceptions;
 
-
 use Exception;
 
 class CacheFileNotFoundException extends Exception

tests/CacheTest.php

@@ -3,6 +3,8 @@
 namespace MaartenGDev\Tests;
 
 use MaartenGDev\Cache;
+use MaartenGDev\Exceptions\BadMethodCallException;
+use MaartenGDev\Exceptions\CacheEntryNotFound;
 use MaartenGDev\Exceptions\CacheFileNotFoundException;
 use MaartenGDev\LocalDriver;
 use PHPUnit_Framework_TestCase;
@@ -41,4 +43,39 @@ public function testCacheIsValidWithInvalidItemGivesFileNotFoundException(){
 
         $fileDoesNotExist = $this->cache->isValid('hello_world_invalid',5);
     }
+
+    public function testCallHasItemInCacheWithInvalidClosure(){
+
+        $stored = $this->cache->store('hello_world','Hello world!');
+
+        $this->expectException(BadMethodCallException::class);
+        $this->cache->has('hello_world','invalid closure');
+    }
+
+    public function testHasItemInCacheWithClosureReturnsClosureReturnValue(){
+
+        $stored = $this->cache->store('hello_world','Hello world!');
+
+        $hasItem = $this->cache->has('hello_world',function(){
+            return 'correct';
+        });
+
+        $this->assertEquals('correct',$hasItem);
+    }
+
+    public function testGetCacheItemThatDoesNotExist(){
+
+        $this->expectException(CacheFileNotFoundException::class);
+
+        $this->cache->get('invalid_cache_item_name');
+    }
+
+    public function testGetCacheItemThatDoesExist(){
+        $stored = $this->cache->store('cache_entry_name','New Entry Here');
+
+        $cacheItem = $this->cache->get('cache_entry_name');
+
+        $this->assertEquals($cacheItem,'New Entry Here');
+    }
+
 }