Fixed parameter naming for HDBSCAN #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected `min_topic_size` to proper HDBSCAN parameter `min_cluster_size`` - Fixed value for parameter `min_cluster_size` in code line to 40 according to textual description
|
Thanks for the fix! LGTM 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Maarten
I think I noticed two small errors in the documentation and fixed these.
min_topic_sizeto proper HDBSCAN parametermin_cluster_sizemin_cluster_sizein code line to40according to textual descriptionAwesome library by the way! Thanks a ton for making this available. Very much appreciated! 馃憤