Disable WebView's cache #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MacDownApp#746 image cache issue
|
Created PR #748 with commit implementing what I mentioned in the side note above |
|
Oooooh this is nice. How did you even find this API? |
This was referenced Feb 6, 2017
Closed
|
@uranusjr googling. Lots of googling 😊 I found it mentioned somewhere. |
|
Man, why would this API be private at all?! |
|
@FranklinYu there are public APIs for managing the cache of |
|
If that's the case, this gets convoluted only because we try to support Mountain Lion and Mavericks? |
|
Yes. |
This was referenced Jan 11, 2022
buzzert
added a commit
to buzzert/macdown
that referenced
this pull request
Jan 12, 2022
For issue MacDownApp#747, a change was introduced that uses private API to disable caching on the preview pane's web view. This was ostensibly to make it so that if images referenced in the markdown document are changed on disk, their changes are reflected in the preview pane. Unfortunately, perhaps due to some underlying changes to WebKit/WebView, disabling caching will also disable caching for all sorts of other things like stylesheets and the base html document loaded from disk. This results in a momentary flash of empty content if one is typing quickly. Reverting the changes for MacDownApp#747 resolves the flashing issue, but does regress the issue regarding images being persistently cached. However, the flashing issue appears to be bothering more people than the image issue, so I believe it would be appropriate to temporarily regress the image caching bug to resolve the flashing bug. Supposedly, a plan exists to migrate to WKWebView, which would hopefully resolve both of these issues simultaneously.
mdznr
pushed a commit
to mdznr/macdown
that referenced
this pull request
Oct 22, 2022
For issue MacDownApp#747, a change was introduced that uses private API to disable caching on the preview pane's web view. This was ostensibly to make it so that if images referenced in the markdown document are changed on disk, their changes are reflected in the preview pane. Unfortunately, perhaps due to some underlying changes to WebKit/WebView, disabling caching will also disable caching for all sorts of other things like stylesheets and the base html document loaded from disk. This results in a momentary flash of empty content if one is typing quickly. Reverting the changes for MacDownApp#747 resolves the flashing issue, but does regress the issue regarding images being persistently cached. However, the flashing issue appears to be bothering more people than the image issue, so I believe it would be appropriate to temporarily regress the image caching bug to resolve the flashing bug. Supposedly, a plan exists to migrate to WKWebView, which would hopefully resolve both of these issues simultaneously.
shankerwangmiao
pushed a commit
to shankerwangmiao/macdown
that referenced
this pull request
Nov 12, 2022
For issue MacDownApp#747, a change was introduced that uses private API to disable caching on the preview pane's web view. This was ostensibly to make it so that if images referenced in the markdown document are changed on disk, their changes are reflected in the preview pane. Unfortunately, perhaps due to some underlying changes to WebKit/WebView, disabling caching will also disable caching for all sorts of other things like stylesheets and the base html document loaded from disk. This results in a momentary flash of empty content if one is typing quickly. Reverting the changes for MacDownApp#747 resolves the flashing issue, but does regress the issue regarding images being persistently cached. However, the flashing issue appears to be bothering more people than the image issue, so I believe it would be appropriate to temporarily regress the image caching bug to resolve the flashing bug. Supposedly, a plan exists to migrate to WKWebView, which would hopefully resolve both of these issues simultaneously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #746 image cache issue. Using private API
[WebCache setDisabled:YES]to disabled the cache ofWebView. The cache should be disabled, right? Or is there any reason for keeping it enabled?Feel so so about using private API. Kinda okay since MacDown isn't in the app store. A long term solution is probably what @uranusjr suggested in the #746 comments - migrating to using
WKWebViewinstead ofWebView. That might solve this issue as well.With this fix image will be reloaded when reloading preview or removing and re-adding the image markdown.
Side note: Another small nice feature might be to trigger a reload of the preview when MacDown enters foreground? Then changes made to images in another application would automatically be updated when returning to MacDown.