Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Add wheels building for all platforms #7

Merged
merged 37 commits into from Nov 24, 2017
Merged

Add wheels building for all platforms #7

merged 37 commits into from Nov 24, 2017

Conversation

menshikh-iv
Copy link
Collaborator

@menshikh-iv menshikh-iv commented Nov 23, 2017

Copy link
Contributor

@matthew-brett matthew-brett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

appveyor.yml Outdated


# Install the build and runtime dependencies of the project.
- "%CMD_IN_ENV% pip install --timeout=60 --trusted-host 28daf2247a33ed269873-7b1aad3fab3cc330e1fd9d109892382a.r6.cf2.rackcdn.com --find-links http://28daf2247a33ed269873-7b1aad3fab3cc330e1fd9d109892382a.r6.cf2.rackcdn.com/ numpy==1.11.3 scipy==0.18.1 smart_open pytest pytest-rerunfailures cython pyemd testfixtures scikit-learn Morfessor==2.0.2a4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use normal pip / pypi for these wheels? You'd need to start at scipy 1.0 but otherwise, as far as I know, you'd be alright.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we need to test with 0.18.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test that on travis / linux + OSX, and test scipy 1.0 on Windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do need these packages, probably better to use the https address : https://8003f898b26602186ccc-7b1aad3fab3cc330e1fd9d109892382a.ssl.cf2.rackcdn.com

# Upload the generated wheel package to Rackspace
# On Windows, Apache Libcloud cannot find a standard CA cert bundle so we
# disable the ssl checks.
- "python -m wheelhouse_uploader upload --no-ssl-check --local-folder=. gensim-wheels"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add the container name - in this case (for a release) wheels.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But gensim-wheels is container name, or I missed something?

appveyor.yml Outdated
install:
# Install Python (from the official .msi of http://python.org) and pip when
# not already installed.
- "powershell ./appveyor/install.ps1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you don't need this - Python should already be installed for the all versions you need.

@menshikh-iv
Copy link
Collaborator Author

Thanks @matthew-brett for the review!
Small question - what's the difference between cpXY-cpXYm and cpXY-cpXYmu wheels (I think that this depends on UNICODE_WIDTH parameter)? I don't understand, should I add both variants for python2 on linux?

@matthew-brett
Copy link
Contributor

Right - I think mu is a UCS4 wide Unicode build. I believe that both narrow and wide builds exist out in the wild, so yes, it's good to build both.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants