Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

test 1.1.x - DO NOT MERGE #93

Closed
wants to merge 6 commits into from

Conversation

simonjayhawkins
Copy link
Collaborator

@simonjayhawkins
Copy link
Collaborator Author

still have failures here. these have started appearing

=========================== short test summary info ===========================
FAILED test_venv/lib/site-packages/pandas/tests/io/excel/test_style.py::test_styler_to_excel[xlwt]
= 1 failed, 63973 passed, 7373 skipped, 1044 xfailed, 14 warnings in 579.59s (0:09:39) =

@TomAugspurger
Copy link
Contributor

If it's a pytest-xdist crash then perhaps just restart that job once the others finish..

@simonjayhawkins
Copy link
Collaborator Author

If it's a pytest-xdist crash then perhaps just restart that job once the others finish..

I don't have access here but also failed on previous run.

once #94 and pandas-dev/pandas#35809 we should be passing here.

will wait and see!

@TomAugspurger
Copy link
Contributor

If it's easier, you can also skip here by updating

python -c 'import sys; import pandas; pandas.test(extra_args=["-m not clipboard", "--skip-slow", "--skip-network", "--skip-db", "-n=2", "-k not test_maybe_promote_int_with_int and not test_missing_required_dependency"]) if sys.version_info[:2] != (3, 7) else None'
.

@simonjayhawkins
Copy link
Collaborator Author

yes currently do that, but probably cleaner to be consistent with other 32bit test failures

@simonjayhawkins
Copy link
Collaborator Author

@TomAugspurger things looking more healthy here so I think ready to tag the release.

only failure here

=========================== short test summary info ===========================
FAILED test_venv/lib/site-packages/pandas/tests/io/parser/test_common.py::test_file_descriptor_leak[c_high]
= 1 failed, 64044 passed, 7331 skipped, 1018 xfailed, 16 warnings in 416.67s (0:06:56) =

I though this was fixed (passed in 43d0888 after xdist pin), but must be a flaky test.

We could add that to skip list in PR for RLS1.1.1 to build wheels or restart?

cc @jreback

@TomAugspurger
Copy link
Contributor

Maybe best to just skip it here? If the build doesn't pass a wheel won't be uploaded.

@TomAugspurger
Copy link
Contributor

@matthew-brett can you or anyone else who has access here add @simonjayhawkins to the pandas-builders team so he can restart builds if necessary?

@simonjayhawkins
Copy link
Collaborator Author

Maybe best to just skip it here? If the build doesn't pass a wheel won't be uploaded.

will open another PR for that (the auto generated one) in the meantime #94 should be merged?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 20, 2020 via email

@simonjayhawkins simonjayhawkins mentioned this pull request Aug 20, 2020
@simonjayhawkins simonjayhawkins deleted the test-1.1.x branch August 20, 2020 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants