Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
locate needed executables on demand, bring back -V (verbose mode)
- Loading branch information
Laurent Sansonetti
committed
Apr 6, 2011
1 parent
31ab6cf
commit 46c64f4
Showing
1 changed file
with
36 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46c64f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, sorry for the bug!
46c64f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the #locate method could use a class-level cache? Sorry I haven't thought of the performance penalty of locating programs for every Compiler instance :)
(I introduced that change because there was a bug when running rubyc / locating llc on a system without MacRuby installed, and it made more sense to locate the programs at demand).
46c64f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm? I mean that even though you reverted some of the changes, the compiler is still way faster than in MacRuby 0.10.
I benchmarked again and the difference from before you reverted to after is (almost) insignificant.
46c64f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, well I guess I can blame lack of sleep for the misunderstanding :) Glad to know nothing has to change.