Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when editing a video the thumbnails show incorrect number #132

Closed
spirogg opened this issue Jun 7, 2020 · 4 comments
Closed

when editing a video the thumbnails show incorrect number #132

spirogg opened this issue Jun 7, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@spirogg
Copy link

spirogg commented Jun 7, 2020

  • Hi when we add the thumb nail plugin and and in admin area we have it set to 2 thumbnails
    admin area> General Configurations > Website Configurations > Uploading and Conversion Settings >go to bottom and select > Conversion Settings in the field add 2

  • then go see how many thumbnails show when you edit that video and see what the number of thumbs says?

  • we log back into admin area and edit that video and we look it shows 10?

  • but we only have 2 seems its multiples of 5

  • so if we have 2 selected will show 2x5=10

total thumnails

  • if we have 5 selected and we get 5 it will show 5x5=25

Number of thumbs 5

  • and now go to edit videos see it shows 25 thumbs

thimbnails 5 shows 25

@MacWarrior MacWarrior self-assigned this Jun 7, 2020
@MacWarrior MacWarrior added the bug Something isn't working label Jun 7, 2020
@spirogg
Copy link
Author

spirogg commented Jun 7, 2020

@MacWarrior also when we go to admin area > General Configurations > Reports & Stats

all the way at the bottom it shows 97 thumbnails
original videos 1 user thumb files 4

I think these numbers don;t make sense either I have 5 videos and total thumbs that show when I edit each video to view how many thumbs, then I add and count all thumbs and there are only 19 thumbnail in total for 5 videos.

  • so my question is where can i actually go see how many thumbnails there are to verify ( in what folder) is it generate the thumbs ?

  • I want to make sure its not generating 97 for 5 videos only

Total Files Sizes
Total Files: 13 Folder Size: 511.1 MB
Total Thumbs: 97 Folder Size: 1.4 MB
Original Video Files: 1 Folder Size: 15 bytes
User Thumbs Files: 4 Folder Size: 6.5KB
User Background Files: 1 Folder Size: 0 bytes
Category Thumb Files: 1 Folder Size: 4.2KB
DataBase Size: 1.6 MB Folder Size: 1.6 MB

@MacWarrior
Copy link
Owner

Hello,

Thumbs are generated in multiples sizes : (Cf. ffmpeg.class.php ; $thumbs_res_settings ; L.24 )

  • original video size
  • 168x105
  • 416x260
  • 632x395
  • 768x432

This means we should get a maximum of :
NUMBER OF VIDEOS x NUMBER OF THUMBS x NUMBER OF SIZES (5)

In my case, I have 50 thumbs, 767 videos which should make a total of 38.350 (767 x 50 x 5)

Values in video detail or in Reports & Stats page aren't stored in DB but calculated (That's why it take me time to load Reports & Stats page)

On recent imported video, I always get the correct amount of thumbs on each videos
But I detected orphan thumbs after video deletion and total count seemd to also count directories (0 videos, 210 orphan thumbs, total counted 212)

Will check this

Best regards,
MacWarrior.

@MacWarrior
Copy link
Owner

Note : In fact, it count ALL files in /upload/thumbs/
So default and necessary files are also counted ; I will definitely fix that

clement-sanz added a commit that referenced this issue May 30, 2023
Miscellaneous : Cleanup code
@MacWarrior
Copy link
Owner

Hi @spirogg,

Issue has been fixed a few time ago

Best regards,
MacWarrior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants