TIMOB-9550: BlackBerry: Implement App elements needed for KitchenSink #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-9550: BlackBerry: Implement App elements needed for KitchenSink [Added] NativeSimpleDBInterface.cpp NativeSimpleDBInterface.h TiAppObject.cpp TiAppObject.h TiAppPropertiesObject.cpp TiAppPropertiesObject.h [Changes] NativeMessageStrings.h - added Create_table_failed TiMessageStrings.h - fixed order - added Invalid_argument_expected_, Type_does_not_match TiTitaniumObject.cpp - added TiAppObject [Tests] Test 1: Run the test app from Jira 1) Create a project and replace app.js with the one from the Jira 2) Build, package, and run the app 3) Verify the text matches the expected output and the persistent bool is false 4) Close and rerun the app and verify the persistent bool is true
| db_.open(); | ||
| Q_ASSERT(db_.isOpen()); | ||
| QSqlQuery query(db_); | ||
| query.exec("CREATE TABLE IF NOT EXISTS " + table_ + " (simpleKey CHAR(10) PRIMARY KEY, simpleValue TEXT)"); |
There was a problem hiding this comment.
Why don't use VARCHAR here to not make key fixed length? Could there be cases when App have multiple values for key? What about unicode key/values?
There was a problem hiding this comment.
Done.
Can't have multiple values for a key. I'm not sure we support anything but UTF-8.
|
Reviewed. |
|
Also I've noticed that R6 lets you store and manage data in JSON format. So, since you're converting everything to json, isn't it reasonable to use that feature? |
[Added] NativeException.cpp NativeException.h [Changes] NativeMessageStrings.h - added error strings NativeSimpleDBInterface.cpp - throw exceptions - change simpleKey to VARCHAR(255) NativeSimpleDBInterface.cpp/h, TiAppPropertiesObject.cpp/h - use const string& TiAppPropertiesObject.cpp - fix formatting - convert NativeException to ThrowException
|
Updated. As discussed, the R6 JSON stuff is only to store single JSON objects |
|
Approved with minor comment |
explicated NativeException ctors
jpl-mac
pushed a commit
that referenced
this pull request
Jul 24, 2012
TIMOB-9550: BlackBerry: Implement App elements needed for KitchenSink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Alex
[Issues Fixed]
TIMOB-9550: BlackBerry: Implement App elements needed for KitchenSink
[Added]
NativeSimpleDBInterface.cpp
NativeSimpleDBInterface.h
TiAppObject.cpp
TiAppObject.h
TiAppPropertiesObject.cpp
TiAppPropertiesObject.h
[Changes]
NativeMessageStrings.h
TiMessageStrings.h
TiTitaniumObject.cpp
[Tests]
Test 1: Run the test app from Jira