TIMOB-10226: BlackBerry: Build script trigger wrong build type #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: JP Changelog: - Add the VARIANTLIST to make command. Test cases: - Build the mobile sdk. - Create project using project.py. - Build it with builder.py using different build types (simulator, device, deploy). - Make sure it builds with correct build type. NOTE: Will fail to build with build type 'deploy' due to known issue with R6.
| assert os.path.exists(project) | ||
| templateDir = os.path.abspath(os.path.dirname(sys._getframe(0).f_code.co_filename)) | ||
| cpuList = 'CPULIST=' + cpu | ||
| bbRoot = 'BB_ROOT=' + templateDir | ||
| variant = 'VARIANTLIST=' + ('g' if variant[-2:] == '-g' else '') |
There was a problem hiding this comment.
trivial: would be easier to read and understand if it used if variant.endswith('-g')
|
Please add to the description an explanation of what the issue is/was and how it presents itself. And why/how this change fixes the issue. This should be standard for any bug fix review. So far i can't see any reference to VARIANTLIST in the makefiles. But i see VARIANTS being used. |
Reviewers: JP Description: "blackberry\builder.py run -t device" command triggers Device-Release build, while should trigger Device-Debug. Setup the VARIANT_LIST macro (defined from qrules.mk) within make command to direct it to the proper build. Changelog: - Minor change. Test cases: - Build the mobile sdk. - Create project using project.py. - Build it with builder.py using different build types (simulator, device, deploy). - Make sure it builds with correct build type. NOTE: Will fail to build with build type 'deploy' due to known issue with R6.
|
Updated. |
|
I still can't understand it, i can see VARIANT_LIST in qmacros.mk but no reference to VARIANTLIST anywhere in the mk files within our project except for qde preferences. I ran tests and it does do what you described, and can't argue with that :) Approved |
alexandergalstyan
added a commit
that referenced
this pull request
Aug 1, 2012
TIMOB-10226: BlackBerry: Build script trigger wrong build type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: JP
Description:
"blackberry\builder.py run -t device" command triggers Device-Release build, while should trigger Device-Debug.
Setup the VARIANT_LIST macro (defined from qrules.mk) within make command to direct it to the proper build.
Changelog:
Test cases:
NOTE: Will fail to build with build type 'deploy' due to known issue with R6.