TIMOB-9665 Blackberry: fix property enumeration on JS object created by ... #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by the framework Reviewer: DC The lookup of inherited methods such as toString() was broken for Ti instances that we create, resulting in a crash. The cause is that by returning undefined in the lookup the V8 internal lookup was not invoked. Changelog: - Return an empty value handle when not finding a keyword in our framework - Protect the TiUIBase initializeTiObject so that it can be called from derived classes without negative effects. - Reverted the calls from derived classes to call in their direct parent Tests: Built for simulator, verified that passing a Ti object to a function that expects a string, ends up invoking the toString on the object and it doesn't crash the JS anymore. => verified that the event callbacks are not broken by the change => Using breakpoints, verified that the prop_setter function is still getting called with the change
|
approved |
dcampbell-macadamian
added a commit
that referenced
this pull request
Aug 7, 2012
TIMOB-9665 Blackberry: fix property enumeration on JS object created by ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...the framework
Reviewer: DC
The lookup of inherited methods such as toString() was broken for Ti instances that we create, resulting in a crash.
The cause is that by returning undefined in the lookup the V8 internal lookup was not invoked.
Changelog:
Tests:
Built for simulator, verified that passing a Ti object to a function that expects a string, ends up invoking the toString on the object and it doesn't crash the JS anymore.
=> verified that the event callbacks are not broken by the change
=> Using breakpoints, verified that the prop_setter function is still getting called with the change