TIMOB-10270: BlackBerry: Implement getWidth, getHeight in UI View #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: Davic C.
ChangeLog:
- keep the top, left, height, width, right, left etc properties as JS
properties
Test Cases:
- make sure you can successfully build tibb and tibbte
- run the above snippet of code and make sure right values are printed
for the get, left, etc. positional properties
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
text: 'hello',
width: "200in",
height: "100mm",
left: "10px",
top: "20",
bottom: "345dip",
right: "211pt",
});
var button = Titanium.UI.createButton({
title: 'print position',
top: 300
});
button.addEventListener('click',function(e)
{
Titanium.API.info("You clicked the button");
Titanium.API.info("Height = " + label1.getHeight());
Titanium.API.info("Width = " + label1.getWidth());
Titanium.API.info("Top = " + label1.getTop());
Titanium.API.info("Left = " + label1.getLeft());
Titanium.API.info("Right = " + label1.getRight());
Titanium.API.info("Bottom = " + label1.getBottom());
});
win1.add(label1);
win1.add(button);
win1.open();
| @@ -373,17 +375,24 @@ int NativeControlObject::setFont(TiObject*) | |||
| int NativeControlObject::setHeight(TiObject* obj) | |||
| { | |||
| Q_ASSERT(container_ != NULL); | |||
| if (height_) | |||
There was a problem hiding this comment.
Appcelerator coding standards state that you must use == or != operator, i.e.
if (height_ != NULL)
|
reviewed |
|
patch is updated |
Conflicts: blackberry/tibb/NativeControlObject.cpp blackberry/tibb/NativeControlObject.h
|
approved |
Harutyun
pushed a commit
that referenced
this pull request
Aug 9, 2012
TIMOB-10270: BlackBerry: Implement getWidth, getHeight in UI View
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Davic C.
ChangeLog:
properties
Test Cases:
for the get, left, etc. positional properties
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var label1 = Ti.UI.createLabel({
text: 'hello',
width: "200in",
height: "100mm",
left: "10px",
top: "20",
bottom: "345dip",
right: "211pt",
});
var button = Titanium.UI.createButton({
title: 'print position',
top: 300
});
button.addEventListener('click',function(e)
{
Titanium.API.info("You clicked the button");
Titanium.API.info("Height = " + label1.getHeight());
Titanium.API.info("Width = " + label1.getWidth());
Titanium.API.info("Top = " + label1.getTop());
Titanium.API.info("Left = " + label1.getLeft());
Titanium.API.info("Right = " + label1.getRight());
Titanium.API.info("Bottom = " + label1.getBottom());
});
win1.add(label1);
win1.add(button);
win1.open();