TIMOB-8839: Implement UI.TableViewRow (work in progress) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer: Alex Change Log: - added leftImage and rightImage properties - created NativeListViewRowObject class - added createTableViewRow method to Ti.UI - created TiUITableViewRow class - modified app.js for testing Test Cases: - build tibb - build tibbtest - run tibbtest - a table list with 50 labels should appear Problems: - unable to get left and right images to appear - when clicking on the text of a list item, the selection is off set https://jira.appcelerator.org/browse/TIMOB-8839
| @@ -97,8 +105,16 @@ void NativeListViewObject::setupEvents(TiEventContainerFactory* containerFactory | |||
| /*********** ListViewItemFactory class *************/ | |||
| bb::cascades::VisualNode* ListViewItemFactory::createItem(bb::cascades::ListView*, const QString&) | |||
| { | |||
| bb::cascades::StandardListItem* item = new bb::cascades::StandardListItem(); | |||
| return item; | |||
| TiListViewRow* row = new TiListViewRow(); | |||
There was a problem hiding this comment.
The problem with that (which I had) is that in this case we didn't reuse the rows we alread created which is wrong I think. We need to find way to reuse them.
|
Click event response taking long time to get handled. Not sure why that happenning, but that's probably an urgent issue. |
|
Update apidoc |
|
Add PR Link to JIRA |
|
Merge with upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Alex
Change Log:
Test Cases:
Problems:
https://jira.appcelerator.org/browse/TIMOB-8839