TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part1] #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocket.TCP [part1]
Reviewers: DavidL
Changelog:
- Added NativeTCPSocketObject, TiNetwork, TiSocketObject, TiTCPSocketObject classes
- Added Network.Socket constants
- Implemented port, host properties from Network.Socket.TCP
- Implemented connect, close methods from Network.Socket.TCP
- Updated apidoc
Test cases:
- Use the snippets attached to JIRA to test current functionality.
// Network.Socket.TCP snippet
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var socket = Ti.Network.Socket.createTCP({
host: 'alexg',
port: 8080
});
socket.connect();
var button = Titanium.UI.createButton({
title: 'Stop',
top: 10,
width: 200,
height: 100
});
button.addEventListener('click',function(e)
{
socket.close();
});
win1.add(button);
win1.open();
| @@ -98,6 +98,7 @@ methods: | |||
| type: Dictionary<Titanium.Network.TCPSocket> | |||
| - name: decodeURIComponent | |||
| summary: Returns a decoded version of a URI encoded value. | |||
| platforms: [android, iphone, ipad, mobileweb] | |||
There was a problem hiding this comment.
fix indents, same for the rest of the file
There was a problem hiding this comment.
Also, unregisterForPushNotifications looks like it's for iOS only, can you please check with Appcelerator?
|
Approved with comments. The Appcelerator questions can be addressed in the next PR. |
…ocket.TCP [part1] ver2
Reviewers: DavidL
Changelog:
- Address comments
- Updated apidoc
NOTE: Use local tcp server to check the functionality, wtih both ip address and hostname. Was used TCPMonitor plugin for Eclipse.
Test cases:
- Use the snippets attached to JIRA to test current functionality.
// Network.Socket.TCP snippet
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var socket = Ti.Network.Socket.createTCP({
host: 'alexg',
port: 8080
});
socket.connect();
var button = Titanium.UI.createButton({
title: 'Stop',
top: 10,
width: 200,
height: 100
});
button.addEventListener('click',function(e)
{
socket.close();
});
win1.add(button);
win1.open();
|
Updated |
alexandergalstyan
added a commit
that referenced
this pull request
Aug 16, 2012
TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: DavidL
Changelog:
NOTE: Use local tcp server to check the functionality, wtih both ip address and hostname. Was used TCPMonitor plugin for Eclipse.
Test cases:
// Network.Socket.TCP snippet
var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});
var socket = Ti.Network.Socket.createTCP({
host: 'alexg',
port: 8080
});
socket.connect();
var button = Titanium.UI.createButton({
title: 'Stop',
top: 10,
width: 200,
height: 100
});
button.addEventListener('click',function(e)
{
socket.close();
});
win1.add(button);
win1.open();