(Partial) TIMOB-9543: BlackBerry: Implement BufferStream #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] (Partial) TIMOB-9543: BlackBerry: Implement BufferStream (Partial) TIMOB-10257: BlackBerry: Implement Titanium.IOStream [Added] TiBufferStreamObject.cpp TiBufferStreamObject.h TiIOStreamObject.cpp TiIOStreamObject.h TiStreamObject.cpp TiStreamObject.h [Changes] TiTitaniumObject.cpp - function onCreateStaticMembers - add TiBufferStreamObject and TiStreamObject bootstrap.js - add temporary code to show how to add a function to the API using JavaScript [Tests] Test 1: Test new JavaScript function var bs = Ti.Stream.createStream(); bs.demoFunc(); Expected: Should print the following: [DEBUG]:demoFunc is being run
| } | ||
|
|
||
| Handle<Value> TiStreamObject::_createStream(void* /*userContext*/, TiObject* /*caller*/, const Arguments& args) | ||
| { |
There was a problem hiding this comment.
according to documentation , creatStream should take one and only one argument, do we need to check it here?
There was a problem hiding this comment.
This will be done in a later PR.
|
Is it what we need to make anvil run? (don't we need to implement functions, properties for buffersstream and iostream in this jira task?) |
|
Reviewed |
|
This is just a partial patch. the functions, etc will come later in another PR. |
(Partial) TIMOB-10257: BlackBerry: Implement Titanium.IOStream updated apidoc fixed onCreateStaticMembers calls in TiBufferStreamObject and TiIOStreamObject
|
Updated patch for apidoc and onCreateStaticMembers |
|
Approved |
Conflicts: blackberry/tibb/TiTitaniumObject.cpp
dlifshitz-maca
added a commit
that referenced
this pull request
Aug 16, 2012
(Partial) TIMOB-9543: BlackBerry: Implement BufferStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Harut