TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2] #134

alexandergalstyan · 2012-08-17T15:32:39Z

Reviewers: DavidL

Changelog:

Implement listen, accept methods
Implement state, listenQueueSize, connected, accepted, error properties
Handling exception cases.

NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse.
NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet.

NOTE: Some parts not fully tested yet and not fully implemented.

Test cases:

Use the snippets attached to JIRA to test current functionality.

// Network.Socket.TCP snippet

var win1 = Titanium.UI.createWindow({
backgroundColor:'#F00'
});

/*
var socket = Ti.Network.Socket.createTCP({
host: 'alexg',
port: 8080,
connected : function(e) {
Ti.API.info('Client socket connected! Socket: ' + e.socket.port);
}
});

socket.connect();
*/

//Create a socket and listen for incoming connections
var listenSocket = Ti.Network.Socket.createTCP({
// Simulator IP address
host : '192.168.226.134',
port : 40404
});

// Starts the socket listening for connections, does not accept them
listenSocket.listen();
Ti.API.info("Listening now...");

// Tells socket to accept the next inbound connection. listenSocket.accepted gets
// called when a connection is accepted via accept()
Ti.API.info("Calling accept.");
listenSocket.accept({
timeout : 10000
});

var button = Titanium.UI.createButton({
title: 'Stop',
top: 10,
width: 200,
height: 100
});

button.addEventListener('click',function(e)
{
alert('Hello');
});

win1.add(button);

// open window
win1.open();

…ocket.TCP [part2] Reviewers: DavidL Changelog: - Implement listen, accept methods - Implement state, listenQueueSize, connected, accepted, error properties - Handling exception cases. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. NOTE: Some parts not fully tested yet and not fully implemented. Test cases: - Use the snippets attached to JIRA to test current functionality. // Network.Socket.TCP snippet var win1 = Titanium.UI.createWindow({ backgroundColor:'#F00' }); /* var socket = Ti.Network.Socket.createTCP({ host: 'alexg', port: 8080, connected : function(e) { Ti.API.info('Client socket connected! Socket: ' + e.socket.port); } }); socket.connect(); */ //Create a socket and listen for incoming connections var listenSocket = Ti.Network.Socket.createTCP({ // Simulator IP address host : '192.168.226.134', port : 40404 }); // Starts the socket listening for connections, does not accept them listenSocket.listen(); Ti.API.info("Listening now..."); // Tells socket to accept the next inbound connection. listenSocket.accepted gets // called when a connection is accepted via accept() Ti.API.info("Calling accept."); listenSocket.accept({ timeout : 10000 }); var button = Titanium.UI.createButton({ title: 'Stop', top: 10, width: 200, height: 100 }); button.addEventListener('click',function(e) { alert('Hello'); }); win1.add(button); // open window win1.open();

dlifshitz-maca · 2012-08-17T15:43:58Z

blackberry/tibb/NativeMessageStrings.h

@@ -42,7 +42,8 @@
 N_MESSAGESTRINGS_CONST_DEF(char*, Unknown_key_value_received, "Unknown key:value received");
 N_MESSAGESTRINGS_CONST_DEF(char*, Unknown_value_received, "Unknown value received");
 N_MESSAGESTRINGS_CONST_DEF(char*, Unsupported_event_name_, "Unsupported event name ");
-
+N_MESSAGESTRINGS_CONST_DEF(char*, Invalid_hostname_or_port, "Invalid host name or port");


Please keep this alphabetical

dlifshitz-maca · 2012-08-17T18:16:48Z

Reviewed.

…ocket.TCP [part2] ver2 Changelog: - Address comments. - Update apidoc. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. Test cases: - Use the snippets attached to JIRA to test current functionality.

alexandergalstyan · 2012-08-20T13:30:25Z

Updated

dlifshitz-maca · 2012-08-20T15:30:19Z

Reviewed.

…ocket.TCP [part2] ver3 Changelog: - Address comments. - Code refactoring. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. Test cases: - Use the snippets attached to JIRA to test current functionality.

alexandergalstyan · 2012-08-20T17:11:22Z

Updated.

dlifshitz-maca · 2012-08-20T18:40:46Z

blackberry/tibb/TiV8EventContainer.h

@@ -37,6 +37,7 @@ class TiV8EventContainer : public TiEventContainer
    virtual void setDataProperty(const char* propertyName, float value);
    virtual void setComplexDataProperty(const char* complexPropertyName, const char* propertyName, const char* value);
    virtual void setV8ValueProperty(const char* propertyName, v8::Handle<v8::Value> data);
+    virtual v8::Handle<v8::Value> getDataProperty(const char* propertyName);


should be getV8ValueProperty

dlifshitz-maca · 2012-08-20T20:27:53Z

Reviewed. I'll need your help to set up an environment to fully test with.
Still not quite like addEventListener, but I guess it will do.

…ocket.TCP [part2] ver4 Changelog: - Address comments. - Code refactoring. - Implement write, read methods. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. Test cases: - Use the snippets attached to JIRA to test current functionality. - app.js updated.

alexandergalstyan · 2012-08-21T17:18:56Z

Updated

dlifshitz-maca · 2012-08-22T14:17:14Z

blackberry/tibb/NativeTCPSocketObject.h

+        eventContainer_->fireEvent();
+
+        // Disconnect current slot from signal
+        QObject::disconnect(owner_->tcpServer_, SIGNAL(newConnection()), owner_->eventHandler_, SLOT(accepted()));


This should be done first.

dlifshitz-maca · 2012-08-22T16:07:58Z

Reviewed.

…ocket.TCP [part2] ver5 Changelog: - Address comments. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. Test cases: - Use the snippets attached to JIRA to test current functionality. - app.js updated.

alexandergalstyan · 2012-08-23T09:18:27Z

Updated

dlifshitz-maca · 2012-08-23T13:47:13Z

blackberry/tibb/NativeTCPSocketObject.h

+{
+    Q_OBJECT
+public:
+    explicit TCPSocketEventHandler(TiEventContainer* eventContainer, NativeTCPSocketObject* owner)


I don't like how github changed the sorting of additional comments so I think you missed this one. I'll repost it:
Please add an assert too and get rid of the if (owner_) checks

dlifshitz-maca · 2012-08-23T14:08:26Z

Approved with comments.

…ocket.TCP [part2] ver6 Changelog: - Address comments. NOTE: [Client part] Use local tcp server to check the functionality, with both ip address and hostname. Was used TCPMonitor plugin for Eclipse. NOTE: [Server part] Use hostname and ip address of simulator. Connect to it using telnet. Test cases: - Use the snippets attached to JIRA to test current functionality. - app.js updated.

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2]

dlifshitz-maca reviewed Aug 17, 2012
View reviewed changes

dlifshitz-maca reviewed Aug 20, 2012
View reviewed changes

dlifshitz-maca reviewed Aug 22, 2012
View reviewed changes

dlifshitz-maca reviewed Aug 23, 2012
View reviewed changes

alexandergalstyan added a commit that referenced this pull request Aug 23, 2012

Merge pull request #134 from alexandergalstyan/networkBranchPart2

8458edf

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2]

alexandergalstyan merged commit 8458edf into Macadamian:blackberry Aug 23, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2] #134

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2] #134

alexandergalstyan commented Aug 17, 2012

dlifshitz-maca Aug 17, 2012

alexandergalstyan Aug 20, 2012

dlifshitz-maca commented Aug 17, 2012

alexandergalstyan commented Aug 20, 2012

dlifshitz-maca commented Aug 20, 2012

alexandergalstyan commented Aug 20, 2012

dlifshitz-maca Aug 20, 2012

alexandergalstyan Aug 21, 2012

dlifshitz-maca commented Aug 20, 2012

alexandergalstyan commented Aug 21, 2012

dlifshitz-maca Aug 22, 2012

alexandergalstyan Aug 23, 2012

dlifshitz-maca commented Aug 22, 2012

alexandergalstyan commented Aug 23, 2012

dlifshitz-maca Aug 23, 2012

alexandergalstyan Aug 23, 2012

dlifshitz-maca commented Aug 23, 2012

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2] #134

TIMOB-10137: BlackBerry: Implement Ti.Network.Socket and Ti.Network.Socket.TCP [part2] #134

Conversation

alexandergalstyan commented Aug 17, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlifshitz-maca commented Aug 17, 2012

alexandergalstyan commented Aug 20, 2012

dlifshitz-maca commented Aug 20, 2012

alexandergalstyan commented Aug 20, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlifshitz-maca commented Aug 20, 2012

alexandergalstyan commented Aug 21, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlifshitz-maca commented Aug 22, 2012

alexandergalstyan commented Aug 23, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlifshitz-maca commented Aug 23, 2012