Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(partial) TIMOB-9543: BlackBerry: Implement Ti.BufferStream #137

Merged
merged 1 commit into from Aug 29, 2012

Conversation

dlifshitz-maca
Copy link

Reviewer: Harut

[Issues Fixed]
(partial) TIMOB-9543: BlackBerry: Implement Ti.BufferStream

[Description]
This partial patch implements BufferStream.read and the BufferStream part of Stream.createStream

[Changes]
BufferStream.yml
- update for read()

Stream.yml
- update for createStream

TiBufferStreamObject.cpp/h
- function createBufferStream
  - changed the params to be an Object
  - use the prototype instead of Object::Clone

TiStreamObject.cpp
- function _createStream
  - create the stream based on the source and set up the properties

bootstrap.js
- implement BufferStream.read

[Tests]
Test 1: Run test code
1) Use the app.js attached to the jira
2) Verify the correct parts of the stream are read to the buffer, for each length specified, and that the number of bytes read matches

[Issues Fixed]
(partial) TIMOB-9543: BlackBerry: Implement Ti.BufferStream

[Description]
This partial patch implements BufferStream.read and the BufferStream part of Stream.createStream

[Changes]
BufferStream.yml
- update for read()

Stream.yml
- update for createStream

TiBufferStreamObject.cpp/h
- function createBufferStream
  - changed the params to be an Object
  - use the prototype instead of Object::Clone

TiStreamObject.cpp
- function _createStream
  - create the stream based on the source and set up the properties

bootstrap.js
- implement BufferStream.read

[Tests]
Test 1: Run test code
1) Use the app.js attached to the jira
2) Verify the correct parts of the stream are read to the buffer, for each length specified, and that the number of bytes read matches
@Harutyun
Copy link

Approved

dlifshitz-maca added a commit that referenced this pull request Aug 29, 2012
(partial) TIMOB-9543: BlackBerry: Implement Ti.BufferStream
@dlifshitz-maca dlifshitz-maca merged commit 37af018 into Macadamian:blackberry Aug 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants