TIMOB-10162: BlackBerry: Implement Ti.Stream.pump for Anvil #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer: David L.
Change Log:
- implemented Ti.Stream.pump function in the boostram.js
- fixed an issue with buffer.clear function
Test Cases:
- run the java script , make sure pump is reading from the buffer, and
calling the call back function and callback's arguments values are
correct
- make sure the output is expected
NativeTCPSocketObject.cpp - function read - if can't read, call the error handler bootstrap.js - function Ti.Stream.pump - convert to async pattern app.js - revert
|
Looks ok, approved |
Larochelle
added a commit
that referenced
this pull request
Aug 24, 2012
TIMOB-10162: BlackBerry: Implement Ti.Stream.pump for Anvil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Martin