TIMOB-10557 Blackberry: Getters are not working #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer: David This patch introduces cached getters. In other words, it allows for generic getters for JS properties without requiring to add more C++ code. Changelog: - Updated the alertDialog yml doc - Removed c++ implemented getters that are not longer needed - Added NO_BRIDGE properties flags, (no bridge is the same as cached) - Modified onValueChange to no invoke the callback when it's null, but still forceset the value on the JS object - Set the READ_NO_BRIDGE flag on all readable properties - Modified setTiMappingProperties to not pass the callback when the NO_BRIDGE flag is set - removed warning Tests: - Tested that the generic getters work and replace the c++ implementations appropriately - Tested the generic getters on the alertDialog, ensure that buttonNames returns an array app.js file used for tests attached to JIRA ticket
| @@ -99,11 +99,11 @@ properties: | |||
|
|
|||
| A maximum of 3 buttons is supported on Android. | |||
|
|
|||
| On BlackBerry, a confirm and cancel button automatically will be created if none are | |||
There was a problem hiding this comment.
How about:
On BlackBerry, 'Cancel' and 'OK' buttons will be automatically created if none are explicitly defined. Providing buttonNames will omit these buttons and use those provided instead.
|
Approved with comments. Please have QA verify the subtasks. |
…ms line from View.yml
jpl-mac
pushed a commit
that referenced
this pull request
Aug 28, 2012
TIMOB-10557 Blackberry: Getters are not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: David
This patch introduces cached getters. In other words, it allows for generic getters for JS properties without requiring to add more C++ code.
Changelog:
Tests:
app.js file used for tests attached to JIRA ticket