TIMOB-10638: BlackBerry: Cannot read from Socket.TCP #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: David C. Changelog: - Fixed an issue with buffer clear - fix issue with TCP socket call backs (All the callbacks were called whenever one of them should be called) - refactor TCP socket callbacks Test Cases: - make sure you can successfully build tibb and tibbtest - use app.js (as server) and client.js (as client) js files attached to jira task - run app on emulator - run client.js with node - make sure client and server received data and connected call back is called - make sure error callback is not called - make sure when you press button it sends data to the client Test Case
| int size = internalData_.size(); | ||
| internalData_.clear(); | ||
| internalData_.resize(size); | ||
| internalData_.fill('\0'); |
There was a problem hiding this comment.
Please also make sure there are \0 in setLength. I'm thinking something like this:
int oldSize = internalData_.size();
if (lengthValue > oldSize)
{
internalData_.append(QByteArray(lengthValue - oldSize, '\0'));
}
else
{
internalData_.truncate(lengthValue);
}
|
Reviewed |
|
patch is updated |
| @@ -89,6 +89,9 @@ class NativeProxyObject: public NativeObject | |||
| // Ti event types (tet) | |||
| static const char* tetCHANGE; | |||
| static const char* tetCLICK; | |||
| static const char* tetCONNECTED; | |||
| static const char* tetACCEPTED; | |||
There was a problem hiding this comment.
fix order (sorry I missed this one)
|
Reviewed. |
|
patch is updated |
|
Approved |
Harutyun
pushed a commit
that referenced
this pull request
Aug 31, 2012
TIMOB-10638: BlackBerry: Cannot read from Socket.TCP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: David L.
Changelog:
whenever one of them should be called)
Test Cases:
jira task
called