TIMOB-10706 Blackberry: getValue doesn't return the current value when m... #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n modification happens via UI interaction Reviewer: Harut Changelog: - Updated Slider apidoc to mark support for value prop - Added tiObject field for pointer to correspondinf TiObject in NativeObject's - Removed need for a NativeOptionObject class as it has no Ti API equivalent - added updateValue function in NSliderO, NSwitchO and NTextFieldO to set the value from the cascades signal in the JS object - Made the ToggleButton::checkedChanged signal work by removing param name in connect statement - Added TiObject::forceSetProp to set the value on the js without setting it on the NO as this is already done in cases where the change was done via the UI Removed files: NativeOptionObject.* Tests: - Tested that the value property is updated correctly when modifying via the UI - Verified that it still is updated properly when set programmatically
| @@ -23,7 +23,8 @@ | |||
| static const char* FONT_WEIGHT_NORMAL = "normal"; | |||
| static const char* FONT_WEIGHT_BOLD = "bold"; | |||
|
|
|||
| NativeAbstractTextControlObject::NativeAbstractTextControlObject() | |||
| NativeAbstractTextControlObject::NativeAbstractTextControlObject(TiObject* tiObject) | |||
| : NativeControlObject(tiObject) | |||
| { | |||
| textControl_ = NULL; | |||
There was a problem hiding this comment.
add this into initialization list as well
|
Approved. Following test was done:
|
jpl-mac
pushed a commit
that referenced
this pull request
Sep 5, 2012
TIMOB-10706 Blackberry: getValue doesn't return the current value when m...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...odification happens via UI interaction
Reviewer: Harut
Changelog:
Removed files: NativeOptionObject.*
Tests: