TIMOB-10820 Blackberry: Upgrade to R8 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2012 17:21
Reviewer: Josh Changelog: - Upgrade to using cascades R8 - updated the mkspecs in Makefile - Removed DockLayoutProperties as the class no longer exists and it is ignored if the parent control doesn't have a DockLayout, which was the case in our code - updated classes that have been renamed - Removed warnings and fixed some member var names - unset parent of controls after removing them, otherwise it now stays in the parent and could get deleted with the parent Tests: - Built the tibbtest to verify that everything builds and is functional - install the mobile sdk in studio and built KS. There is an issue with selecting list items, i will investigate and post the fix in a separate PR
Fixed issues related to KS operations Changelog: - Use triggered signal for listView selection - Use default PaneProperties for NativeTabObject to fix back behaviour - Removed unused vars - Commented out using the cached result inside require implementation as it doesn't work as expected - Renamed static private functions for naming scheme consistency Tests: - Ran tibbtest in the simulator using tibbtest and verified the list selection works normally and repeatedly -- Verified that the back button works all the time (was working only once before)
|
Tested and reviewed changes. Accepted |
joshthecoder
added a commit
that referenced
this pull request
Sep 19, 2012
TIMOB-10820 Blackberry: Upgrade to R8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: Josh
Changelog:
Tests: