TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] (partial) TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts [Added] blackberry.js - note: there is some commented-out code that should be ignored for now [Changed] index.html, drillbit.js, drillbit.py, drillbit_sdk.py, drillbitTest.js, drillbitmodule.js - added BlackBerry counterparts drillbit.py - added the user's app data location to the search path [Tests] Test 1: Run drillbit 1) Run one of the following commands: drillbit\drillbit.py --platforms=android or drillbit\drillbit.py --platforms=blackberry or drillbit\drillbit.py --platforms=android,blackberry or drillbit\drillbit.py --platforms=blackberry,android 2) Verify the tests are shown 3) Click "run tests" 4) Verify the tests are run Note: the BlackBerry tests will not complete because the building step is not implemented yet
|
|
||
| // TODO: the above needs to be implemented in blackberryndk.py. For now just fake it: | ||
| result = "BLACKBERRY_NDK=C:\\bbndk-10.0.03"; | ||
|
|
There was a problem hiding this comment.
We have blackberry NDK detection in blackberryndk.py, so probably no need in this.
There was a problem hiding this comment.
The lines above were taken from the android version, but I put the TODO there to fix things in another patch.
|
Can run the tests, but for blackberry it seems hang on issuing make. Have you noticed such issue? |
|
As discussed, make doesn't run for blackberry yet for these tests. |
|
Approved |
|
Addressed comments. |
|
|
||
| BlackBerrySimulator.prototype.fillTiAppData = function(data) { | ||
| if(data.androidRuntime === undefined) { | ||
| data.androidRuntime = "none"; |
There was a problem hiding this comment.
yes, really. see iphone.js
dlifshitz-maca
added a commit
that referenced
this pull request
May 10, 2012
TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts
[Issues Fixed]
(partial) TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts
[Added]
blackberry.js
note: there is some commented-out code that should be ignored for now
[Changed]
index.html, drillbit.js, drillbit.py, drillbit_sdk.py, drillbitTest.js, drillbitmodule.js
added BlackBerry counterparts
drillbit.py
added the user's app data location to the search path
[Tests]
Precondition: need to build mobile sdk using scons
Test 1: Run drillbit
1) Run one of the following commands:
drillbit\drillbit.py --platforms=android
or
drillbit\drillbit.py --platforms=blackberry
or
drillbit\drillbit.py --platforms=android,blackberry
or
drillbit\drillbit.py --platforms=blackberry,android
2) Verify the tests are shown
3) Click "run tests"
4) Verify the tests are run
Note: the BlackBerry tests will not complete because the building step is not implemented yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, Harut
Note: you need to install Titanium Desktop 1.2. Links can be found under the Running Drillbit section of http://docs.appcelerator.com/titanium/2.0/index.html#!/guide/Writing_Unit_Tests_with_Drillbit
[Issues Fixed]
(partial) TIMOB-8943: BlackBerry: Add BlackBerry to drillbit scripts
[Added]
blackberry.js
[Changed]
index.html, drillbit.js, drillbit.py, drillbit_sdk.py, drillbitTest.js, drillbitmodule.js
drillbit.py
[Tests]
Precondition: need to build mobile sdk using scons
Test 1: Run drillbit
drillbit\drillbit.py --platforms=android
or
drillbit\drillbit.py --platforms=blackberry
or
drillbit\drillbit.py --platforms=android,blackberry
or
drillbit\drillbit.py --platforms=blackberry,android
Note: the BlackBerry tests will not complete because the building step is not implemented yet