TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app [Changed] tiapp_harness.xml - added blackberry xmlns blackberry.js - function installTestHarness - added suite parameter - call launchTestHarness - function launchTestHarness - added suite parameter - build, deploy, and run the test_harness app - function runTestHarness - pass 'blackberry' to handleTestError - set the status to Running - pass the suite parameter drillbitmodule.js - function initPlatforms - fix getting the env vars - function handleTestError - added parameter platform and use 'android' as the default for backwards compatability blackberryndk.py, builder.py - use return code [Tests] Test 1: Run drillbit 1) Build tibb 2) change simulator IP in builder.py 3) Run scons to build the mobile sdk 4) Run the following command: drillbit\drillbit.py --platforms=blackberry 5) Verify the tests are shown 6) Click "run tests" 7) Verify the test_harness app is build and deployed Note: the BlackBerry tests will not complete because communication with the simulator is not implemented
| if (platform === undefined) { | ||
| platform = 'android'; | ||
| } | ||
| this.frontendDo('test_platform_status', suite.name, 'Error', platform); | ||
| this.frontendDo('test_status', suite.name, 'Error') | ||
| this.testDuration = (new Date().getTime() - this.testsStarted)/1000; |
There was a problem hiding this comment.
Note: V8 doesn't implement basic JavaScript objects such as "Date". We're going to need implement a bunch of JS functions and objects.
|
Reviewed |
|
Approved |
|
Updated patch. |
dlifshitz-maca
added a commit
that referenced
this pull request
May 14, 2012
TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app [Issues Fixed] TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app [Changed] tiapp_harness.xml - added blackberry xmlns blackberry.js - function installTestHarness - added suite parameter - call launchTestHarness - function launchTestHarness - added suite parameter - build, deploy, and run the test_harness app - function runTestHarness - pass 'blackberry' to handleTestError - set the status to Running - pass the suite parameter drillbitmodule.js - function initPlatforms - fix getting the env vars - function handleTestError - added parameter platform and use 'android' as the default for backwards compatability blackberryndk.py, builder.py - use return code [Tests] Test 1: Run drillbit 1) Build tibb 2) change simulator IP in builder.py 3) Run scons to build the mobile sdk 4) Run the following command: drillbit\drillbit.py --platforms=blackberry 5) Verify the tests are shown 6) Click "run tests" 7) Verify the test_harness app is build and deployed Note: the BlackBerry tests will not complete because communication with the simulator is not implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: JP, David C
[Issues Fixed]
TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app
[Changed]
tiapp_harness.xml
blackberry.js
drillbitmodule.js
blackberryndk.py, builder.py
[Tests]
Test 1: Run drillbit
drillbit\drillbit.py --platforms=blackberry
Note: the BlackBerry tests will not complete because communication with the simulator is not implemented