Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-8783 BlackBerry: Implement Global APIs Part 1 #51

Merged
merged 1 commit into from May 15, 2012

Conversation

jpl-mac
Copy link

@jpl-mac jpl-mac commented May 11, 2012

Reviewers: Harut, Alex

This patch adds all the stubs for all the methods and objects in the Global Namespace

Changelog:

  • Add global methods to the root object
  • Add String and JSON objects to the root object
  • Removed unnecessary forward declaration in TiUIObject

New files:

  • blackberry/tibb/TiJSONObject.cpp
  • blackberry/tibb/TiJSONObject.h
  • blackberry/tibb/TiStringObject.cpp
  • blackberry/tibb/TiStringObject.h

Tests:

  • Build tibb and tibbtest for all targets except for Device-Release as it is currently broken

Reviewers: Harut, Alex

This patch adds all the stubs for all the methods and objects in the Global Namespace

Changelog:
- Add global methods to the root object
- Add String and JSON objects to the root object
- Removed unnecessary forward declaration in TiUIObject

New files:
- blackberry/tibb/TiJSONObject.cpp
- blackberry/tibb/TiJSONObject.h
- blackberry/tibb/TiStringObject.cpp
- blackberry/tibb/TiStringObject.h

Tests:
- Build tibb and tibbtest for all targets except for Device-Release as it is currently broken
@alexandergalstyan
Copy link

Looks ok for now. The things I've noticed are:

  1. Replace the static functions functionName (prefix underline) with functionName (suffix underline), to be consistent with the rest of code.
  2. Replace the TODO's with TODO Mac.

@jpl-mac
Copy link
Author

jpl-mac commented May 14, 2012

  1. Good eye Alex for the underscore.
    Suffix underline is for member variable which the static functions are not. So we'll be using the prefixed underline for the private static functions. The others should have been changed but went in because the framework needed to be merged. All future private static functions that we create for callbacks will be with the prefix. And existing one should be modified as we go, there is also a Jira issue that was created to track the issue with the original ones to be changed to prefix underscore.
  2. We need TODO Mac for shared files with Appcel, as these are new files that we control, the Mac part is not necessary.

@Harutyun
Copy link

Aproved

@alexandergalstyan
Copy link

Approved

jpl-mac pushed a commit that referenced this pull request May 15, 2012
TIMOB-8783 BlackBerry: Implement Global APIs Part 1
@jpl-mac jpl-mac merged commit 864d83c into Macadamian:blackberry May 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants