TIMOB-8926: Blackberry: Implement proper packaging of blackberry mobile sdk #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-9014: BlackBerry: Add BlackBerry to drillbit test harness app [Changed] tiapp_harness.xml - added blackberry xmlns blackberry.js - function installTestHarness - added suite parameter - call launchTestHarness - function launchTestHarness - added suite parameter - build, deploy, and run the test_harness app - function runTestHarness - pass 'blackberry' to handleTestError - set the status to Running - pass the suite parameter drillbitmodule.js - function initPlatforms - fix getting the env vars - function handleTestError - added parameter platform and use 'android' as the default for backwards compatability blackberryndk.py, builder.py - use return code [Tests] Test 1: Run drillbit 1) Build tibb 2) change simulator IP in builder.py 3) Run scons to build the mobile sdk 4) Run the following command: drillbit\drillbit.py --platforms=blackberry 5) Verify the tests are shown 6) Click "run tests" 7) Verify the test_harness app is build and deployed Note: the BlackBerry tests will not complete because communication with the simulator is not implemented
…le sdk
[Issues Fixed]
TIMOB-8926: Blackberry: Implement proper packaging of blackberry mobile sdk
[Added]
blackberry/tibb/.gitignore
- ignore *.a
[Changes]
SConstruct
- import BlackberryNDK
- fix build_type butchering for clean builds
- build tibb
package.py
- function zip_blackberry
- only zip the following:
- .h and .a files for libv8 and tibb
- tibbapp
blackberryndk.py
- added function buildTibb
[Tests]
Test 1: Build and use mobile sdk
1) Run scons
2) Verify the mobilesdk/win32/2.0.0/blackberry folder only contains what is needed
3) Run scons clean
4) Verify the build files are gone
Test 2: Use the mobile sdk
1) Run scons
2) Extract the sdk so Titanium Studio can use it
3) Open Titanium Studio and create a new project
4) Verify the templates were created properly
5) Run for simulator
6) Verify the app is built, deployed, and run
| if not (file.endswith('.h') or file.endswith('.a')): | ||
| continue | ||
| e = os.path.splitext(file) | ||
| from_ = os.path.join(root, file) |
There was a problem hiding this comment.
Variable e is not used.
Also we lost everything which is not .h or .a file, say common.mk, Makefiles get lost,
I think we need to copy everything currently in that dirs, and then make build or anything we want to do on newly created items.
There was a problem hiding this comment.
We don't need the makefiles because the users won't be building the library since they already have the libtibb.a files.
There was a problem hiding this comment.
you're right. remove e then, since it is not used.
|
Reviewed |
|
Talked to Dave following the demo and we don't need to package all the .h files, pretty only need the static libs and the tibb.h that is included by the main.cpp |
|
Approved with minor comment #52 (comment) |
- add build looging (and ignore the file) - rename buildType and output - removed extra .gitignore - removed unused variable - don't include the unneeded .h files in tibb
|
Patch updated. |
Conflicts: drillbit/modules/drillbit/0.1.0/blackberry.js drillbit/modules/drillbit/0.1.0/drillbitmodule.js support/blackberry/blackberryndk.py support/blackberry/builder.py
- change log level - only package tibb.h and not the .h files for libv8
|
Approved |
1 similar comment
|
Approved |
dlifshitz-maca
added a commit
that referenced
this pull request
May 23, 2012
TIMOB-8926: Blackberry: Implement proper packaging of blackberry mobile sdk
[Issues Fixed]
TIMOB-8926: Blackberry: Implement proper packaging of blackberry mobile sdk
[Added]
blackberry/tibb/.gitignore
ignore *.a
[Changes]
SConstruct
import BlackberryNDK
fix build_type butchering for clean builds
build tibb
package.py
function zip_blackberry
only zip the following:
.h and .a files for libv8 and tibb
tibbapp
blackberryndk.py
added function buildTibb
[Tests]
Test 1: Build and use mobile sdk
1) Run scons
2) Verify the mobilesdk/win32/2.0.0/blackberry folder in the zip only contains what is needed
3) Run scons clean
4) Verify the build files are gone
Test 2: Use the mobile sdk
1) Run scons
2) Extract the sdk so Titanium Studio can use it
3) Open Titanium Studio and create a new project
4) Verify the templates were created properly
5) Run for simulator
6) Verify the app is built, deployed, and run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, JP
Note: Only review 855adcb and later
[Issues Fixed]
TIMOB-8926: Blackberry: Implement proper packaging of blackberry mobile sdk
[Added]
blackberry/tibb/.gitignore
[Changes]
SConstruct
package.py
blackberryndk.py
[Tests]
Test 1: Build and use mobile sdk
Test 2: Use the mobile sdk